fix role_playing_game test according to instructions#444
Open
GioeleBucci wants to merge 1 commit intoexercism:mainfrom
Open
fix role_playing_game test according to instructions#444GioeleBucci wants to merge 1 commit intoexercism:mainfrom
GioeleBucci wants to merge 1 commit intoexercism:mainfrom
Conversation
The exercise's instructions say: "If they player's level is below 10, their mana should be untouched."
Since the test checked against `None` there were unintended solutions that did not account for the player level, such as:
`Some(Player(..player, health: 100, mana: option.map(player.mana, fn(_){ 100 })))`
lpil
reviewed
Apr 1, 2024
Member
lpil
left a comment
lpil
left a comment
There was a problem hiding this comment.
Hello! Isn't this unchanged and thus correct both before and after this change?
Author
It is indeed correct, but the test uses |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The exercise's instructions say: "If they player's level is below 10, their mana should be untouched."
Since the test checked against
Nonethere were unintended solutions that did not account for the player level, such as:Some(Player(..player, health: 100, mana: option.map(player.mana, fn(_){ 100 })))